Conversation
|
@gtagle Can you please review the following for accuracy/any feedback and approve if it looks good? 🙏🏻 Updated workflows docsThese got an edit to make sure the wording matched the newer UI and updated screenshots where relevant. Not that significant of a change, but just in case: Working with model workflowsMostly updated the screenshots: Customize model lifecycle statusesVery minor adjustment: Set up model workflowsEdited some of the instructions to line up with the new UI text, and redid some examples/screenshots: |
PR SummaryThis pull request introduces several enhancements to the release scripts and workflow documentation:
These changes aim to improve user experience by providing clearer instructions and automating certain tasks in the release process. Test Suggestions
|
gtagle
left a comment
There was a problem hiding this comment.
Have a look at the comment and let me know if you'd want me to go over this again.
PR SummaryThis pull request introduces several enhancements to the release scripts and workflow documentation:
Test Suggestions
|
|
A PR preview is available: Preview URL |
* Add make execute PROFILE=exe-prod to docs-site action (#598) * Add execute PROFILE=exe-prod to Docker image build * Move notebook execution into docs-site action * Docs — Customize model overview page (#622) * Draft customize-model-overview-page.qmd * Quick instructions * Edits based on feedback from Rod * Updated docs — Workflows (#620) * Tweak to release generation notebook * Wait, gotta make the file first * Wording in notebook * Just being picky about spaces now * Adding open file to yearly_cleanup.py too * Success * Edits to customize-model-lifecycle-statuses.qmd * New img - working-with-model-workflows.qmd > See workflow statuses * +reset-workflow.gif to working-with-model-workflows.qmd * Updated set-up-model-workflows.qmd > Configure workflow steps * Updated configure-user-action.png * Updated approval-group-setup.png * Redid the Approval Step example/images * Redid the Condition Branch example/images * Changed linked-workflow image to a gif * Updated set-up-model-workflows.qmd > Link approval steps * Changed my mind about the model-workflows.png screencap * Tweak * Simplifying based on Rod's suggestion * QoL improvements to release notes script/notebooks (#626) * Testing adding the year to generated release notes * oops, forgot to parse the date format * Now the folder is swapped ugh * Adding the year to the _quarto.yml entry * Oops, forgot to add the input * Casing * Adding new year folder to index function * Grabbing yearly folders in established year * Fake 2025 releases for testing & modifying Makefile command * Fake 2026 release for yearly cleanup test * Trying the yearly lookup again * Yearly lookup works * Retrieve year folder * Commenting out move releases for now * Removed move releases * Modifying update_quarto_yaml * Cleaning up the Makefile command * Notebook wording cleanup * Removing test files & reverting _quarto.yml & index.qmd to main * Added aliases for moved 2024 releases * Added aliases for moved 2023 releases * Whoops, wrong alias for some of the super old releases * Nitpicky edit * Meh * Nitpicking the output * Added instructions for Wait steps in workflows (#628) * Edits to date & date-time custom fields * Wait step draft * Edits & footnotes --------- Co-authored-by: Nik Richers <nik@validmind.ai> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Internal Notes for Reviewers
Updated workflows docs
These got an edit to make sure the wording matched the newer UI and updated screenshots where relevant. Not that significant of a change, but just in case:
Working with model workflows
Mostly updated the screenshots:
LIVE PREVIEW
Customize model lifecycle statuses
Very minor adjustment:
LIVE PREVIEW
Set up model workflows
Edited some of the instructions to line up with the new UI text, and redid some examples/screenshots:
LIVE PREVIEW
More release notebook QoL improvements
Since I figured it out in validmind/validmind-library#282, both the new releases generation and yearly cleanup notebook now open up the file that it creates on your behalf for you so you don't have to go looking for it (the
release-notes.qmdfile for the former, and the{year}-releases.qmdfor the latter).