Skip to content

Updated docs — Workflows#620

Merged
validbeck merged 19 commits intomainfrom
beck/sc-7372/documentation-design-support-for-workflows
Jan 10, 2025
Merged

Updated docs — Workflows#620
validbeck merged 19 commits intomainfrom
beck/sc-7372/documentation-design-support-for-workflows

Conversation

@validbeck
Copy link
Collaborator

@validbeck validbeck commented Jan 7, 2025

Internal Notes for Reviewers

sc-7372

Updated workflows docs

These got an edit to make sure the wording matched the newer UI and updated screenshots where relevant. Not that significant of a change, but just in case:

Working with model workflows

Mostly updated the screenshots:

LIVE PREVIEW

Customize model lifecycle statuses

Very minor adjustment:

LIVE PREVIEW

Set up model workflows

Edited some of the instructions to line up with the new UI text, and redid some examples/screenshots:

LIVE PREVIEW

More release notebook QoL improvements

Since I figured it out in validmind/validmind-library#282, both the new releases generation and yearly cleanup notebook now open up the file that it creates on your behalf for you so you don't have to go looking for it (the release-notes.qmd file for the former, and the {year}-releases.qmd for the latter).

@validbeck validbeck added the internal Not to be externalized in the release notes label Jan 7, 2025
@validbeck validbeck self-assigned this Jan 7, 2025
@validbeck
Copy link
Collaborator Author

@gtagle Can you please review the following for accuracy/any feedback and approve if it looks good? 🙏🏻

Updated workflows docs

These got an edit to make sure the wording matched the newer UI and updated screenshots where relevant. Not that significant of a change, but just in case:

Working with model workflows

Mostly updated the screenshots:

LIVE PREVIEW

Customize model lifecycle statuses

Very minor adjustment:

LIVE PREVIEW

Set up model workflows

Edited some of the instructions to line up with the new UI text, and redid some examples/screenshots:

LIVE PREVIEW

@validbeck validbeck requested review from gtagle and nrichers January 7, 2025 23:15
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR Summary

This pull request introduces several enhancements to the release scripts and workflow documentation:

  1. Release Scripts Enhancements:

    • In generate-release-notes.ipynb, the script now provides additional guidance on creating release folders and files, and it automatically opens the newly created release-notes.qmd file.
    • In generate_release_objects.py, a subprocess is added to open the release notes file in VS Code, with error handling for potential exceptions.
    • In year-end-cleanup.ipynb, similar enhancements are made to open the newly created yearly release file automatically.
    • In yearly_cleanup.py, subprocess functionality is added to open the yearly release file in VS Code, with error handling.
  2. Workflow Documentation Updates:

    • Updates to _configure-workflow-steps.qmd and _link-workflow-steps.qmd include clarifications on step configurations and linking steps, with improved instructions and animations.
    • _model-workflows-see.qmd and working-with-model-workflows.qmd are updated to include callouts for hover animations and improved visual aids.
    • customize-model-lifecycle-statuses.qmd and set-up-model-workflows.qmd have been updated for clarity in instructions and terminology, such as changing "Add Model Lifecycle Status modal" and "User Roles".

These changes aim to improve user experience by providing clearer instructions and automating certain tasks in the release process.

Test Suggestions

  • Test the creation of release folders and files to ensure they are correctly named and opened in VS Code.
  • Verify that the error handling works when VS Code is not available or the subprocess fails.
  • Check the updated workflow documentation for clarity and accuracy in the instructions.
  • Ensure that the animations and images in the documentation are correctly displayed and relevant.
  • Test the subprocess functionality in different environments to ensure compatibility.

Copy link
Collaborator

@gtagle gtagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at the comment and let me know if you'd want me to go over this again.

@validbeck validbeck requested a review from gtagle January 10, 2025 22:04
@github-actions
Copy link
Contributor

PR Summary

This pull request introduces several enhancements to the release scripts and workflow documentation:

  1. Release Scripts Enhancements:

    • In generate-release-notes.ipynb, the script now provides additional guidance by opening the newly created release-notes.qmd file automatically after creation.
    • In generate_release_objects.py, a new feature has been added to open the release notes file in VS Code after creation. This is done using a subprocess.run call, with error handling to catch and print any exceptions that occur during the process.
    • In year-end-cleanup.ipynb, similar functionality is added to open the newly created yearly release file automatically.
    • In yearly_cleanup.py, the script now attempts to open the copied template file in VS Code, with error handling for any exceptions.
  2. Workflow Documentation Updates:

    • Updates to the workflow configuration guides to improve clarity and user experience.
    • Changes in the instructions for adding and configuring workflow steps, including the use of double-click to open configuration modals and updated button labels.
    • Enhanced visual aids with updated screenshots and GIFs to better illustrate the workflow processes.
    • Added callouts to highlight interactive elements, such as hover animations for workflow steps.
    • Adjustments to the terminology used in the documentation to align with current UI elements, such as changing "User group" to "User Roles".
  3. Miscellaneous:

    • Minor text adjustments and formatting improvements across various documentation files to enhance readability and consistency.

Test Suggestions

  • Test the creation of release notes to ensure the file opens automatically in VS Code without errors.
  • Verify that the error handling for opening files in VS Code works correctly by simulating a failure scenario.
  • Check the updated workflow documentation for accuracy and clarity, ensuring all steps are correctly described.
  • Test the new workflow step configuration process to ensure the double-click functionality works as intended.
  • Review the updated visual aids in the documentation to confirm they accurately represent the current UI.
  • Ensure that all references to 'User group' have been updated to 'User Roles' in the documentation.

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

Copy link
Collaborator

@gtagle gtagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to go

@validbeck validbeck merged commit 2cee9e4 into main Jan 10, 2025
4 checks passed
@validbeck validbeck deleted the beck/sc-7372/documentation-design-support-for-workflows branch January 10, 2025 22:20
validbeck added a commit that referenced this pull request Jan 22, 2025
* Add make execute PROFILE=exe-prod to docs-site action  (#598)

* Add execute PROFILE=exe-prod to Docker image build

* Move notebook execution into docs-site action

* Docs — Customize model overview page (#622)

* Draft customize-model-overview-page.qmd

* Quick instructions

* Edits based on feedback from Rod

* Updated docs — Workflows (#620)

* Tweak to release generation notebook

* Wait, gotta make the file first

* Wording in notebook

* Just being picky about spaces now

* Adding open file to yearly_cleanup.py too

* Success

* Edits to customize-model-lifecycle-statuses.qmd

* New img - working-with-model-workflows.qmd > See workflow statuses

* +reset-workflow.gif to working-with-model-workflows.qmd

* Updated set-up-model-workflows.qmd > Configure workflow steps

* Updated configure-user-action.png

* Updated approval-group-setup.png

* Redid the Approval Step example/images

* Redid the Condition Branch example/images

* Changed linked-workflow image to a gif

* Updated set-up-model-workflows.qmd > Link approval steps

* Changed my mind about the model-workflows.png screencap

* Tweak

* Simplifying based on Rod's suggestion

* QoL improvements to release notes script/notebooks (#626)

* Testing adding the year to generated release notes

* oops, forgot to parse the date format

* Now the folder is swapped ugh

* Adding the year to the _quarto.yml entry

* Oops, forgot to add the input

* Casing

* Adding new year folder to index function

* Grabbing yearly folders in established year

* Fake 2025 releases for testing & modifying Makefile command

* Fake 2026 release for yearly cleanup test

* Trying the yearly lookup again

* Yearly lookup works

* Retrieve year folder

* Commenting out move releases for now

* Removed move releases

* Modifying update_quarto_yaml

* Cleaning up the Makefile command

* Notebook wording cleanup

* Removing test files & reverting _quarto.yml & index.qmd to main

* Added aliases for moved 2024 releases

* Added aliases for moved 2023 releases

* Whoops, wrong alias for some of the super old releases

* Nitpicky edit

* Meh

* Nitpicking the output

* Added instructions for Wait steps in workflows (#628)

* Edits to date & date-time custom fields

* Wait step draft

* Edits & footnotes

---------

Co-authored-by: Nik Richers <nik@validmind.ai>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nrichers nrichers added documentation Improvements or additions to documentation and removed internal Not to be externalized in the release notes labels Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants